Add PRETTIFY_SQL setting to control token grouping in SQL panel - #1438
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1438 +/- ##
==========================================
+ Coverage 87.44% 87.46% +0.01%
==========================================
Files 29 29
Lines 1577 1579 +2
Branches 220 221 +1
==========================================
+ Hits 1379 1381 +2
Misses 146 146
Partials 52 52
Continue to review full report at Codecov.
|
tim-schilling
requested changes
Jan 21, 2021
tim-schilling
left a comment
Member
There was a problem hiding this comment.
Well done! I appreciate the example in the documentation.
| The SQL panel highlights queries that took more that this amount of time, | ||
| in milliseconds, to execute. | ||
|
|
||
| * ``PRETTIFY_SQL`` |
Member
There was a problem hiding this comment.
Can you move this above PROFILER_MAX_DEPTH to make the settings alphabetical please?
It doesn't validate what PRETTIFY_SQL does explicitly, but that toggling it changes the output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1402, this PR expose a new setting, "PRETTIFY_SQL" which controls token grouping in SQL panel.
It is set as True by default in order to preserve current behaviour.
It should be disabled if a django application makes a very long textual SQL query, which will cause a huge slowdown during toolbar render.
This is a new PR (original #1404) to fix some commit issues as reported in this comment.