Skip to content

Fix #1434: Mention the need to run collectstatic in the installation notes #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matthiask
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1449 (f385c38) into master (254ff24) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   87.86%   87.68%   -0.19%     
==========================================
  Files          29       29              
  Lines        1591     1591              
  Branches      224      224              
==========================================
- Hits         1398     1395       -3     
- Misses        142      145       +3     
  Partials       51       51              
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 86.60% <0.00%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254ff24...ee3ed22. Read the comment docs.

@matthiask
Copy link
Member Author

sqlite tests are failing because Django@master (the upcoming 4.0) has dropped support for Python 3.6 and 3.7. See #1450

@tim-schilling
Copy link
Member

I was under the impression that collectstatic is only needed in DEBUG = False environments. I feel like there's an underlying issue that should be investigated.

@matthiask matthiask marked this pull request as draft February 10, 2021 17:19
@matthiask
Copy link
Member Author

Good point.

Also, we shouldn't recommend running collectstatic in development.

Base automatically changed from master to main February 11, 2021 15:01
@matthiask matthiask closed this Apr 24, 2021
@matthiask matthiask deleted the 1434-collectstatic branch December 9, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants