Fix for missing __name__ attribute when using class based views (i.e. FormWizard) #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used If view_func doesn't have a __name__ attribute, then __class__.__name__ is tried instead. If that doesn't exist either, then '<unknown>' is used.
dcramer
added a commit
that referenced
this pull request
May 10, 2011
Fix for missing __name__ attribute when using class based views (i.e. FormWizard)
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Fix for missing __name__ attribute when using class based views (i.e. FormWizard)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to the
contentmethod in the RequestVarsDebugPanel, so that if theview_funcdoesn't have a__name__attribute, the__class__.__name__will be tried instead.Otherwise,
<unknown>is used to save anAttributeErrorbeing raised if neither exist.This issue became apparent when using a form wizard, though I think Django 1.3's class-based views should be safe due to the way they are instantiated (
ViewClass.as_view()).