Skip to content

Add check and docs for TEMPLATES APP_DIRS=False. #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Add check and docs for TEMPLATES APP_DIRS=False. #1498

merged 2 commits into from
Aug 28, 2021

Conversation

tim-schilling
Copy link
Member

The toolbar requires at least one DjangoTemplates TEMPLATES
configuration needs to have APP_DIRS set to True.

Closes #1491

The toolbar requires at least one DjangoTemplates TEMPLATES
configuration needs to have APP_DIRS set to True.
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #1498 (be21a99) into main (6cc6265) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
+ Coverage   85.72%   85.84%   +0.12%     
==========================================
  Files          35       35              
  Lines        1891     1893       +2     
  Branches      272      273       +1     
==========================================
+ Hits         1621     1625       +4     
+ Misses        190      189       -1     
+ Partials       80       79       -1     
Impacted Files Coverage Δ
debug_toolbar/apps.py 92.72% <100.00%> (+0.27%) ⬆️
debug_toolbar/panels/profiling.py 91.07% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc6265...be21a99. Read the comment docs.

@tim-schilling tim-schilling merged commit e20ac73 into django-commons:main Aug 28, 2021
@tim-schilling tim-schilling deleted the templates-app-dirs branch August 28, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include instructions on APP_DIRS in Prerequisites docs
2 participants