Support for multi-db SQL views #155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an update (mostly geared at Rob) I've added tons of SQL support in my branch, but I overlooked some of the things that are in this patch (such as passing the alias to the SQL commands) |
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some changes to SQL views (and templates) so that they work with multiple databases.
I've only tested it on PostgreSQL, but it should work on other backend, I suppose.
If you find it interesting, please pull.
Cheers!
Tomek