unsigning history forms - #1583
Merged
Merged
Conversation
tim-schilling
approved these changes
Jan 28, 2022
tim-schilling
left a comment
Member
There was a problem hiding this comment.
Thanks for making this a separate PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1577 Removing the signing feature of the history forms.
Arguments for the change: It doesn't really provide any security and makes working with them harder.
I can't personally think of a situation where an attacker has access to the debug toolbar + store_id + real database, but as is so often true with security it could be a not obvious exploit - please weigh in if this code is providing value!