Drop support for Python 3.7 #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dba0050 to
aaa5305
Compare
|
@tim-schilling I added a removal of Django 4.0 to this since the end of the extended support is close and our CI matrix is already really big. Everything should still work with 4.0 but we don't spend CI time verifying it over and over. |
matthiask
commented
Jan 20, 2023
| @@ -27,13 +27,13 @@ classifiers = [ | |||
| "Framework :: Django :: 3.2", | |||
| "Framework :: Django :: 4.0", | |||
| "Framework :: Django :: 4.1", | |||
| # "Framework :: Django :: 4.2", | |||
There was a problem hiding this comment.
The identifier doesn't seem to be available yet.
| @@ -70,7 +70,7 @@ def get_config(): | |||
| ] | |||
|
|
|||
|
|
|||
| @lru_cache() | |||
| @lru_cache | |||
There was a problem hiding this comment.
Automatically changed by pyupgrade.
|
Another option to dropping 4.0 from the test suite entirely is to only test it with sqlite with the latest version of python it supports. |
aaa5305 to
3a761c1
Compare
|
Good idea. I left |
3a761c1 to
346b461
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request drops support for Python 3.7. Older versions of the toolbar will still be usable by people still using 3.7. This also makes us use less CI resources, something which is a big plus for me.
Also, see https://pythonspeed.com/articles/stop-using-python-3.7/
Checklist:
docs/changes.rst.