SQL panel fix for locales that use comma as a decimal separator. #173
Conversation
|
Quite mistakinbly I've added another commit to this pull request. Is it still pullable properly? Anyway - the second patch fixes another problem - when a "djDebugLineChart" container is shifted with the "left" CSS property its width changes accordingly. Therefore the width of a "<strong>" inside must be scaled relatively to the remaining space. |
|
Do you know what's actually being printed localized? Do ints automatically get localized in templates or is there some other magic? |
|
I've noticed that floating points numbers are localized - here in Poland we use comma as a decimal separator, but this is true for other countries as well (France I guess?). |
|
ups! |
|
@thinred do you know if thats any float that you print in the templates? |
SQL panel fix for locales that use comma as a decimal separator.
|
Seems that the localization does automatically format it (from what I'm told). I'll try to get a test case added for this (unless you beat me to it :) |
|
An obvious moral from this bug is to be very careful when floating-point number is used in HTML attributes. :) |
SQL panel fix for locales that use comma as a decimal separator.
I've noticed this problem some time ago. "width_ratio" and "start_offset" were printed with comma as a separator (I use polish locale) and this confused CSS parser. I couldn't find a way to forcibly print a number in a dotted notation so I rolled out my own template filter.