Added psycopg3 support #1739
Merged
Added psycopg3 support #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@tim-schilling please add your changes for |
|
Sorry, I dropped the ball on this. |
|
This is getting closer. I'm struggling to get |
|
It turns out we were never running the postgis test suite. That's been fixed. |
|
Phew, that is done. |
updated trans_id to rely on transaction status instead of connection status as it works with pyscorg3 Use correct json property based on psycopg version Skip test_tuple_param_conversion if using psycopg3 Move psycopg3 skip logic into decorator.
tim-schilling
approved these changes
Feb 25, 2023
|
@matthiask can you double check the changes for me? |
|
For what it's worth, I just tested it with the following and it works:
Thank you 🙌 |
matthiask
approved these changes
Feb 28, 2023
islam-kamel
approved these changes
Feb 28, 2023
islam-kamel
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for psycopg3 while still keeping support for psycopg2
Fixes #1736
Checklist:
docs/changes.rst.tests.panels.test_sql.SQLPanelMultiDBTestCase.test_transaction_status