Skip to content

Add Python 3.12 to the test matrix. - #1816

Merged
tim-schilling merged 6 commits into
django-commons:mainfrom
tim-schilling:python-3.12
Oct 14, 2023
Merged

Add Python 3.12 to the test matrix.#1816
tim-schilling merged 6 commits into
django-commons:mainfrom
tim-schilling:python-3.12

Conversation

@tim-schilling

Copy link
Copy Markdown
Member

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@tim-schilling

tim-schilling commented Jul 23, 2023

Copy link
Copy Markdown
Member Author

This is failing due to python/cpython#107088 which causes <listcomp> to no longer appear in the cProfile stats. On the plus side, we can likely remove this test for future versions of python if that's the case. Though ideally we'd have a better way to tell a user that this code is a problem.

Comment thread docs/changes.rst Outdated
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
@tim-schilling

Copy link
Copy Markdown
Member Author

This is blocked by psycopg/psycopg#626

We could bypass this by using psycopg

@adamchainz adamchainz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like psycopg released a compatible package so the CI can be rerun.

@tim-schilling
tim-schilling merged commit 036e8db into django-commons:main Oct 14, 2023
@tim-schilling
tim-schilling deleted the python-3.12 branch October 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants