Toolbar Displays to External IPs

[jasonkeene]

I think there might be a regression introduced here.

SHA: 384d144

I previously assumed any IPs not listed in settings.INTERNAL_IPS would never see the debug toolbar, even if the project was in debug mode. That was the behavior previously.

if not remote_addr in settings.INTERNAL_IPS

After that expression the rest didn't matter, just short circuits to True, jumps into the suite and returns False.

Currently, if I am in debug mode it forces display of the toolbar no matter what, even if I am accessing from a non-internal IP:

if not (remote_addr in settings.INTERNAL_IPS or settings.DEBUG):
        # remote_addr is external (False)       # project is in DEBUG (True)
        # or evaluates to (True)
   # entire expression is negated (False)

So now the condition isn't met and we don't jump into the suite and wind up returning True.

I'm not sure this is the behavior you want.

[jasonkeene]

Closed, resubmitted here so I can have my master back.