(edited) Fix for issue #187 and URL name resolution in RequestVarsPanel #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequestVarsDebugPanel is using a different method to get info about a view. This renders the previous tests obsolete. I changed them so that they check if the URL resolving is done correctly.
Conflicts: tests/tests.py
Author
|
I am closing this - this is included in issue #187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for mixing 2 different issues in one pull request...
Issue #187:
Mike and myself, we were working hard to fix issue #187. This is a result of our cooperation.
URL name resolution:
I wanted to get URL name inside request information so I added it. Also I have reworked the code a little bit. I find it more readable. According to the docs, the code should be portable to Django < 1.3. (commit fabd101)