Skip to content

Fixed #1682 -- alert user when using file field without proper encoding #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-schilling merged 8 commits into from
Jul 4, 2024
Merged

Fixed #1682 -- alert user when using file field without proper encoding #1933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
97fa2e5
Fixed issue #1682 -- alert user when using file field without proper …
bkdekoning Jun 7, 2024
00dc765
Changed issues to alerts, added docstring to check_invalid_... functi…
bkdekoning Jun 8, 2024
0bbb66d
Update AlertsPanel documentation to list pre-defined alert cases
bkdekoning Jun 8, 2024
c332a6f
added check for file inputs that directly reference a form, including…
bkdekoning Jun 11, 2024
d89ee73
Update the alert messages to be on the panel as a map.
tim-schilling Jul 3, 2024
11872eb
Expose a page in the example app that triggers the alerts panel.
tim-schilling Jul 3, 2024
e8dd720
Move the alerts panel below the more used panels.
tim-schilling Jul 3, 2024
28e15a7
Missed a period.
tim-schilling Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the alerts panel below the more used panels.
  • Loading branch information
@tim-schilling
tim-schilling committed Jul 3, 2024
commit e8dd720b978734641f1fcb58e428e48ddcd08610
2 changes: 1 addition & 1 deletion debug_toolbar/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def get_config():


PANELS_DEFAULTS = [
"debug_toolbar.panels.alerts.AlertsPanel",
"debug_toolbar.panels.history.HistoryPanel",
"debug_toolbar.panels.versions.VersionsPanel",
"debug_toolbar.panels.timer.TimerPanel",
Expand All @@ -68,6 +67,7 @@ def get_config():
"debug_toolbar.panels.sql.SQLPanel",
"debug_toolbar.panels.staticfiles.StaticFilesPanel",
"debug_toolbar.panels.templates.TemplatesPanel",
"debug_toolbar.panels.alerts.AlertsPanel",
"debug_toolbar.panels.cache.CachePanel",
"debug_toolbar.panels.signals.SignalsPanel",
"debug_toolbar.panels.redirects.RedirectsPanel",
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ included in the toolbar. It works like Django's ``MIDDLEWARE`` setting. The
default value is::

DEBUG_TOOLBAR_PANELS = [
'debug_toolbar.panels.alerts.AlertsPanel',
'debug_toolbar.panels.history.HistoryPanel',
'debug_toolbar.panels.versions.VersionsPanel',
'debug_toolbar.panels.timer.TimerPanel',
Expand All @@ -30,6 +29,7 @@ default value is::
'debug_toolbar.panels.sql.SQLPanel',
'debug_toolbar.panels.staticfiles.StaticFilesPanel',
'debug_toolbar.panels.templates.TemplatesPanel',
'debug_toolbar.panels.alerts.AlertsPanel',
'debug_toolbar.panels.cache.CachePanel',
'debug_toolbar.panels.signals.SignalsPanel',
'debug_toolbar.panels.redirects.RedirectsPanel',
Expand Down
2 changes: 1 addition & 1 deletion tests/panels/test_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ def test_urls(self):
@override_settings(DEBUG=True)
class HistoryViewsTestCase(IntegrationTestCase):
PANEL_KEYS = {
"AlertsPanel",
"VersionsPanel",
"TimerPanel",
"SettingsPanel",
Expand All @@ -76,6 +75,7 @@ class HistoryViewsTestCase(IntegrationTestCase):
"SQLPanel",
"StaticFilesPanel",
"TemplatesPanel",
"AlertsPanel",
"CachePanel",
"SignalsPanel",
"ProfilingPanel",
Expand Down