-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Async compatible redirect panel #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tim-schilling
merged 11 commits into
django-commons:main
from
salty-ivy:async-panel-patterns
Aug 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
09c0087
aprocess_request pattern in base panel class
salty-ivy 3b990c3
change doctstring
salty-ivy 8bc0784
add docs
salty-ivy b9218ca
update docstring
salty-ivy 8d53311
make redirect panel async capable by using aprocess_request patterm
salty-ivy 003d70b
revert the base panel aprocess_request pattern
salty-ivy 1a2921f
added async compability test for redirect panel
salty-ivy caa32d8
remove redundant call for super process_request
salty-ivy 5ca55d4
added previous missing comment and modfied docs
salty-ivy c9d34af
add space in docs
salty-ivy 60b742c
Add change log.
tim-schilling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
make redirect panel async capable by using aprocess_request patterm
- Loading branch information
commit 8d533112fa704cd8a0b8ceae87b25317931b9c3c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flow will call super().process_request twice. We probably want to avoid that. I have some ideas, but none that I know are great. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since
aprocess_request
is exclusive toRedirectsPanel
process_request
inaprocess_request
as an argument.ASGIRequest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is option 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 2. won't work either : )