Skip to content

Enable a few of the disabled biome rules #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 2, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable the noParameterAssign rule
  • Loading branch information
matthiask committed Mar 2, 2025
commit ad24bbc285877b58d02a8106db2e737bc2779543
1 change: 0 additions & 1 deletion biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
"style": {
"noArguments": "off",
"noParameterAssign": "off",
"useTemplate": "off"
},
"suspicious": {
Expand Down
10 changes: 4 additions & 6 deletions debug_toolbar/static/debug_toolbar/js/toolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,11 @@ const djdt = {
const slowjax = debounce(ajax, 200);

function handleAjaxResponse(storeId) {
storeId = encodeURIComponent(storeId);
const dest = `${sidebarUrl}?store_id=${storeId}`;
const encodedStoreId = encodeURIComponent(storeId);
const dest = `${sidebarUrl}?store_id=${encodedStoreId}`;
slowjax(dest).then(function (data) {
if (djdt.needUpdateOnFetch) {
replaceToolbarState(storeId, data);
replaceToolbarState(encodedStoreId, data);
}
});
}
Expand Down Expand Up @@ -352,9 +352,7 @@ const djdt = {

return cookies[key];
},
set(key, value, options) {
options = options || {};

set(key, value, options = {}) {
if (typeof options.expires === "number") {
const days = options.expires;
const t = (options.expires = new Date());
Expand Down
3 changes: 1 addition & 2 deletions debug_toolbar/static/debug_toolbar/js/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ const $$ = {
};

function ajax(url, init) {
init = Object.assign({ credentials: "same-origin" }, init);
return fetch(url, init)
return fetch(url, Object.assign({ credentials: "same-origin" }, init))
.then(function (response) {
if (response.ok) {
return response.json().catch(function (error) {
Expand Down