Dark Mode Conflict in Pygments Fixed - #2111
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
Member
|
@andoriyaprashant thank you for working on this! Is there a way we can maintain the css variables in this solution? It looks like it's being changed to a series of fixed values that will be difficult to maintain. Not that the variables are super easy to maintain either 😅 |
matthiask
requested changes
Mar 25, 2025
matthiask
left a comment
Member
There was a problem hiding this comment.
Thanks! As Tim said, the CSS variables should stay. They are used in the file and we cannot just remove them.
If you look further down in the file there's already a place where we define #djDebug .highlight colors for the base case, with a comment explaining how to regenerate this section. The dark mode colors should be added below this section I think.
Member
|
Thank you! |
Member
|
Thank you @andoriyaprashant 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR further refines the dark mode styles for Pygments in Django Debug Toolbar. It addresses remaining conflicts by ensuring consistent syntax highlighting with better contrast and readability. This follows up on the previous PR to fully resolve the issue #2096
Fixes #2096
Checklist:
docs/changes.rst.