-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Binary parameter handling for GeoDjango #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fab74c3
Binary parameter handling for GeoDjango
f361a01
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fefdb94
Update the checklist for: have added an item to the Pending section o…
bc395f0
Add DebugToolBarJSONDecoder class for better organization of code
eduzen 2713994
Fix tests for new DebugToolbarJSONDecoder
eduzen 9f9b888
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 217b3a5
Update tests/panels/test_sql_geodjango_fix.py
eduzen 361e84e
Address feedback
eduzen ee01ec4
pre-commit lint
eduzen 05acb9e
Update debug_toolbar/panels/sql/forms.py
eduzen de100bc
Apply suggestions from code review
eduzen 106e8b8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5a3257b
feat: address feedback
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
- Loading branch information
commit f361a013d6881e34c6f4f33015bdbfd6adea8c7f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this logic into a shared utility that way we don't have the magic value
"__djdt_binary__"floating around the code-base. Plus it would be clearer how the logic gets paired together.I'm also curious if we should be using this with the Store logic. If we do, then we could potentially ignore this and handle it within
DebugToolbarJSONEncoderand then haveDebugToolbarJSONDecoderas above. What do you think?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback @tim-schilling ! I think an encoders.py or moving even everything into utils.py is a more consistent way.
About your second question, what do you mean with using the store logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Store logic converts all the panels data into JSON. So this binary parameter would eventually be converted to JSON to be added to the Store. So if the Store handles binary data properly, it may remove the need for the SQL panel to deal with it itself. Does that make more sense?