-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature/task panel #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Feature/task panel #2235
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
16efb32
setup preliminary tasks panel logic
Chiemezuo d4b08ed
Set dummy TasksPanel methods
Chiemezuo afa2297
Experiment with tasks panel
Chiemezuo 6a1a90c
Use tasks support checker in instrumentation method
Chiemezuo 5e3c313
Add TasksPanel to PANEL_KEYS in tests
Chiemezuo c7a81a6
Wrap functools
Chiemezuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
setup preliminary tasks panel logic
- Loading branch information
commit 16efb32b8871d2b0a0001758a216ed60a2695372
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| from django.utils.translation import gettext_lazy as _ | ||
|
|
||
| from debug_toolbar.panels import Panel | ||
|
|
||
|
|
||
| class TasksPanel(Panel): | ||
| """ | ||
| Panel that displays Django tasks queued or executed during the | ||
| processing of the request. | ||
| """ | ||
|
|
||
| title = _("Tasks") | ||
| template = "debug_toolbar/panels/tasks.html" | ||
|
|
||
| is_async = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>Task Info</th> | ||
|
Chiemezuo marked this conversation as resolved.
Outdated
|
||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {% for task in tasks %} | ||
| <tr> | ||
| <td>{{ task }}</td> | ||
| </tr> | ||
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tim-schilling I wonder if it would make sense to check for the Django version here, and only include it if its on a Django version that supports the tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could, but it's possible someone installs
django-tasksin <6.0 version.