Don't blow up if INSTALLED_APPS is a tuple #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since r17158 in Django trunk, INSTALLED_APPS is now not always co-erced to a list. In my projects I prefer to have INSTALLED_APPS as a tuple as it reinforces that it is not modifiable at runtime. However, this blows up in the VersionDebugPanel as it currently assumes it is a list. Signed-off-by: Chris Lamb <lamby@debian.org>
dcramer
added a commit
that referenced
this pull request
Nov 30, 2011
Don't blow up if INSTALLED_APPS is a tuple
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Don't blow up if INSTALLED_APPS is a tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since r17158 in Django trunk, INSTALLED_APPS is now not always co-erced to
a list. In my projects I prefer to have INSTALLED_APPS as a tuple as it
reinforces that it is not modifiable at runtime. However, this blows up
in the VersionDebugPanel as it currently assumes it is a list.
Signed-off-by: Chris Lamb lamby@debian.org