Skip to content

Fix the Django version check in the SQL panel #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiask merged 1 commit into from
Jul 5, 2026
+5 −2
Merged

Fix the Django version check in the SQL panel #2403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix the Django version check in the SQL panel
  • Loading branch information
@matthiask
matthiask committed Jul 5, 2026
commit b7f7d62872e805ec84eeea0eb72816cf77b40351
3 changes: 3 additions & 0 deletions docs/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Change log
Pending
-------

* Fixed the Django version check in the SQL panel test suite for Django's
boolean parameter handling.

7.0.0 (2026-06-17)
------------------

Expand Down
4 changes: 2 additions & 2 deletions tests/panels/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,11 @@ def test_param_conversion(self):
connection.vendor == "mysql"
and django.VERSION >= (4, 1)
or connection.vendor != "postgresql"
and django.VERSION >= (6, 2)
and django.VERSION >= (6, 1)
):
# Django 4.1 started passing true/false back for boolean
# comparisons in MySQL.
# Django 6.2 started passing true/false for all-non
# Django 6.1 started passing true/false for all-non
# postgres databases.
expected_bools = ["Foo", True, False]
else:
Expand Down
Loading