Skip to content

Improve cache hit/miss reporting for cache.get() #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harsh3006 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improve cache hit/miss reporting for cache.get() #2418

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
41911ad
Enhance cache panel to accurately track cache hits and misses for get…
Harsh3006 Jul 15, 2026
6aa94f9
Add tests for cache hits and misses with None and default values
Harsh3006 Jul 15, 2026
391d39c
Update pending section in changes.rst
Harsh3006 Jul 15, 2026
ce6831a
Fix cache hit/miss tracking for keyword arguments in get() method
Harsh3006 Jul 24, 2026
15f47bf
Add test for get_or_set with None to count as cache miss
Harsh3006 Aug 4, 2026
76af105
Refactor cache hit/miss logic in get() method and update related tests
Harsh3006 Aug 10, 2026
91443f5
Add cache hit/miss note to cache panel and documentation
Harsh3006 Aug 10, 2026
e134f2e
docs: clarify cache hit/miss reporting changes
Harsh3006 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for get_or_set with None to count as cache miss
  • Loading branch information
@Harsh3006
Harsh3006 committed Aug 10, 2026
commit 15f47bf8be96abc71b38f0143615ea5630f44ff9
7 changes: 7 additions & 0 deletions tests/panels/test_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ def test_get_or_set_does_not_override_existing_value(self):
},
)

def test_get_or_set_none_counts_as_miss(self):
cache.cache.clear()

self.assertIsNone(cache.cache.get_or_set("foo", None))
self.assertEqual(self.panel.hits, 0)
self.assertEqual(self.panel.misses, 1)

def test_insert_content(self):
"""
Test that the panel only inserts content after generate_stats and
Expand Down