Make show_toolbar_with_docker work when host.docker.internal is not the gateway - #2424
Closed
lowbyteguy wants to merge 1 commit into
Closed
Make show_toolbar_with_docker work when host.docker.internal is not the gateway#2424lowbyteguy wants to merge 1 commit into
lowbyteguy wants to merge 1 commit into
Conversation
…he gateway show_toolbar_with_docker resolved host.docker.internal and shifted the last octet to .1 to guess the Docker host address. On some runtimes, such as OrbStack, that name resolves to an address unrelated to the container network (0.250.250.254), so the computed address never matched REMOTE_ADDR and the toolbar was never shown. Add a second fallback that derives the candidate gateways from the container's own addresses, keeping the existing host.docker.internal check first. Fixes django-commons#2419
Member
|
Closing as a duplicate of #2422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On OrbStack,
host.docker.internalresolves to0.250.250.254, which is unrelated to the container network, so the address computed byshow_toolbar_with_dockernever matchesREMOTE_ADDRand the toolbar is not shown.This keeps the existing
host.docker.internalcheck first and adds a fallback that derives the candidate gateways from the container's own addresses, as suggested in the issue.Fixes #2419
Checklist:
docs/changes.rst.AI/LLM Usage