Don't explode if a project uses tuple'd urlpatterns #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh - sorry for all the whitespace changes! My editor strips whitespace. I'll resubmit with a tighter patch, if you'd like me to. |
dcramer
added a commit
that referenced
this pull request
Mar 14, 2012
Don't explode if a project uses tuple'd urlpatterns
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Don't explode if a project uses tuple'd urlpatterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #235. The toolbar will now work correctly if the Django project's urlpatterns are a tuple, rather than a list.
(We do this because we have lots of apps that re-use another app's URLConf - we tuple-ise the urlpatterns to avoid those apps accidentally mutating the base app's URLs.)