Propagate handler403 value when wrapping urlconf #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +84,8 @@ def process_request(self, request): | |||
| new_urlconf.urlpatterns = debug_toolbar.urls.urlpatterns + \ | |||
| list(urlconf.urlpatterns) | |||
|
|
|||
| if hasattr(urlconf, 'handler403'): | |||
| new_urlconf.handler404 = urlconf.handler403 | |||
There was a problem hiding this comment.
... and I managed to introduce an error in two simple lines of code...
I shouldn't have written them using the online interface, sorry.
It was propagated to handler404 instead of handler403.
dcramer
added a commit
that referenced
this pull request
Jun 3, 2012
Propagate handler403 value when wrapping urlconf
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Propagate handler403 value when wrapping urlconf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor patch to allow overriding handler403 value while using the toolbar.