Skip to content

psycopg2: Avoid causing a 2nd error in an aborted transaction #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
intgr wants to merge 1 commit into from
Closed

psycopg2: Avoid causing a 2nd error in an aborted transaction #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion debug_toolbar/utils/tracking/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,16 @@ def execute(self, sql, params=()):
params.update({
'trans_id': self.logger.get_transaction_id(alias),
'trans_status': conn.get_transaction_status(),
'iso_level': conn.isolation_level,
'encoding': conn.encoding,
})

# This fails when a query aborted the transaction. Avoid
# causing a 2nd exception and hiding the real error
try:
params['iso_level'] = conn.isolation_level
except Exception:
Copy link
Contributor

@nuklea nuklea Nov 15, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't specify exception?

pass

# We keep `sql` to maintain backwards compatibility
self.logger.record(**params)

Expand Down