Request Line is too large (400) sometimes #347
Conversation
nuklea
commented
Dec 27, 2012
- Request Line is too large now excempted, cuz using POST
- Template now is more simple
|
usefull pull request |
|
This seems related to #357 to be honest, I'm closing this here since it doesn't merge cleanly anyway. |
|
@midiotthimble Feel free to collaborate with the author of #357 then :) |
|
@midiotthimble I assumed that while both pull requests tackle the same problem that it would be worthwhile to just work on one version. It wasn't a judgement on the quality. You have my attention now though. Can you explain why you think yours is better? |
|
|
@jezdez what I can do for approval this pull request? |
|
@jezdez This pull request works fine. In my project I have very long queries and now I can't debug that. Please, merge this pull request. |
|
@midiotthimble Not quite yet, lemme make some comments on the code. |
| sql = request.GET.get('sql', '') | ||
| params = request.GET.get('params', '') | ||
| alias = request.GET.get('alias', 'default') | ||
| sql = request.REQUEST.get('sql', '') |
There was a problem hiding this comment.
As far as I understand it's not required anymore to accept those parameters via GET, could you please change to using request.POST instead?
|
@jezdez complete! |
| return hash | ||
|
|
||
| def reformat_sql(self): | ||
| from debug_toolbar.panels.sql import reformat_sql |
There was a problem hiding this comment.
Let's move this to a third module, e.g. debug_toolbar.utils or something match.
There was a problem hiding this comment.
Move what? reformat_sql function?
There was a problem hiding this comment.
@jezdez please, be exactly :)
There was a problem hiding this comment.
Yeah, the reformat_sql function so that the import can be moved at the top of the file. I assume you put the import here to prevent a circular import.
|
@midiotthimble Looks great, thank you! |
|
@jezdez circular import was resolved. |
|
Hm, getting lots of merge conflicts when pull, can you update the pull request with the recent master please? |
…go-debug-toolbar into sql-panel-refactor Conflicts: debug_toolbar/static/debug_toolbar/css/toolbar.min.css debug_toolbar/views.py
|
@jezdez ready! |
|
Don't know how to fix Django 1.5 tests. |
|
Okay, it was an issue with the tests_require setting in setup.py that required Django 1.3-1.5 but not 1.5.x. Can you merge with master again and see if that fixes it? |
|
Oh and definitely add yourself to the AUTHORS file! |
|
I'm not sure that it's my guilty. |
|
Awesome, the failing test was already failing in master! |
Request Line is too large (400) sometimes
|
Thanks for you help @midiotthimble :) |
…factor Request Line is too large (400) sometimes