indentation on session vars #358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea, but don't think this is a good implementation... |
|
your reply is unclear. |
|
i give a result example (a wizard session) with a unit test... If my first commit is really a bad implementation, this test can validate a better work. |
| @@ -252,6 +256,88 @@ def test_queryset_hook(self): | |||
| self.assertIn('<<triggers database query>>', ctx) | |||
|
|
|||
|
|
|||
| class TemplateTagsTestCase(BaseTestCase): | |||
| def test_indent_dict(self): | |||
| input = '''{'step_files': {u'1': {}, u'0': {}, u'3': {}, '''\ | |||
There was a problem hiding this comment.
Please use implied line continuation in strings as mentioned in PEP8
|
thanks jezdez : in fact, it's more beautiful! |
|
I prefer using the built-in |
|
I have committed a simpler solution in 982f341. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find SESSION vars difficult to read, especially when i use wizard forms.
To aerate this, i give a little template filter that indent dict...