Skip to content

Initial fixes to make the debug-toolbar to work with Python 3 using six from django.utils #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Initial fixes to make the debug-toolbar to work with Python 3 using six from django.utils #366

wants to merge 14 commits into from

Conversation

percyperez
Copy link
Contributor

Hello,

I made these initial fixes at PyCon to start porting the debug-toolbar to Python 3. I'm basically using six from django.utils I run the tests but it fails in the SQL panel. The debug-toolbar loads fine in Django 1.5 with python 2.x but in Python 3, the SQL content is missing.

I'm pushing this request if somebody else would like to help and If this is the way you guys would like the changes.

Thanks!

percyperez added 14 commits March 18, 2013 13:48
@percyperez
Fixing exception syntax that works in python >= 2.6
e6b2998
@percyperez
Import _thread for python 3.x and using smart_text
d24c7eb
@percyperez
Importing some python 3 libraries and falling back to python 2.x
48bb7f3
@percyperez
Fixing syntax that works for python 2 and 3
826a428
@percyperez
Fixing dict object has no attribute iteritems by using six.iteritems(…
637417e 
…) from django.utils
@percyperez
Using six.string_types instead of basetring
b30be4a
@percyperez
Use force_text, smart_bytes, and six.iterkeys
3aff519
@percyperez
Passing self.panels as a list to context
66205c0
@percyperez
Using six everywhere
1d13a03
@percyperez
Updating headers.html template to loop calling headers.items
208d02a
@percyperez
Using .items in templates.html and version.html
cf60813
@percyperez
Using _thread from django.utils.six.moves
4bd87fc
@percyperez
Using keys and values instead of iterkeys, itervalues
1d2ce49
@percyperez
Using assertEqual instead of assertEquals
2853ea7
@bkabrda bkabrda mentioned this pull request Mar 27, 2013
Closed
@jezdez
Copy link
Contributor

jezdez commented Apr 23, 2013

Your work is greatly appreciated it but I have to close this in favor of #373.

@jezdez jezdez closed this Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percyperez @jezdez