Indentation for logging message when the dump is an object #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Indentation works best with monospaced fonts. I'd prefer to wrap the output in a |
Contributor
|
Looking at this again today, I'm not sure we want to make changes. Log messages shouldn't contain newlines; that breaks many expectations (eg. grep). Switching to a monospaced font doesn't look very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you want to pretty print your object, instead of doing logging.debug(myobj) you can do
logging.debug(pprint.pformat(myobj)). One problem, pprint uses a space char to indent and that won't work in html, so i added a filter called nbspindent that replaces the spaces created by pprint with so it's proper indented.