Python2.6 - Python3.3 support #374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=> python2.6.5
change attributes "func_code" -> "__code__" and "func_closure" -> "__closure__" ( => python2.6 )
Remove u'' prefix, and import __future__ unicode_literals. Now all strings without the u'' - are Unicode. >>> from __future__ import unicode_literals >>> hasattr(str, '__name__') True
hashlib.sha1 operates on bytes.
same
from __future__ import unicode_literals
|
can you send this pull request to my repo? |
don't allow failures
This commit allows masterbranch to pass all original tests with Django 1.5 (python2).
Django 1.5 introduce python's bultins vars "True", "False", "None" to the Context, as part of BaseContext class:
"""
class BaseContext(object):
def __init__(self, dict_=None):
self._reset_dicts(dict_)
def _reset_dicts(self, value=None):
builtins = {'True': True, 'False': False, 'None': None}
if value:
builtins.update(value)
self.dicts = [builtins]
"""
django/django@93240b7
So, now we always have List's first element that contains these vars.
Should we see this in the django-debug-toolbar?
|
Closing in favor of #373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed code from graingert's pull request. Now it works the same way as in original pypi package on python2.7 + Django1.5.1
Tested it manualy, and it works on Python 2.7.3, 3.2.3 and 3.3.1 version.
As we going to support Django 1.5, i assume we can drop python2.5 support. Just like Django1.5. So we can use futurestatements in code. It makes the code easier to adapt to new versions of python.