Skip to content

Conversation

@DrMeers
Copy link
Contributor

@DrMeers DrMeers commented Jun 25, 2013

Using dirname on SocketServer was wiping out all of the system libraries from the stacktrace, since it is a single-file module unlike Django.

But it is also nice to be able omit things like gunicorn, threading, newrelic, etc as required -- otherwise the DOM structure generated for the stack trace blows out to impractically large proportions with a large number of queries.

May be nice to also add regex filter capabilities for modules which cannot be imported (e.g. gunicorn entry points)

@aaugustin
Copy link
Contributor

I've updated your patch to apply cleanly on master and support Python 3. I've pushed it in 5b1fd5a. Thanks for your contribution.

Tests would have been a plus. If I hadn't performed some last-minute manual testing under Python 3, I would have pushed code that didn't work under Python 3 (because map returns an iterator). If you added tests now, that would be much appreciated. Thank you.

@aaugustin aaugustin closed this Oct 21, 2013
@aaugustin
Copy link
Contributor

If you submit another pull request, please add yourself to AUTHORS too :)

@DrMeers
Copy link
Contributor Author

DrMeers commented Oct 21, 2013

Thanks Aymeric, great to see this repository coming back to life. Yes, I only had time to go so far as making sure none of the existing tests failed. Have added writing specific tests for this to my TODO list, but don't hold your breath!

@aaugustin
Copy link
Contributor

I know... ;-)

@DrMeers DrMeers deleted the master branch February 13, 2014 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants