Skip to content

Updated django.conf.urls.default (deprecated since django 1.4) to django.conf.urls (django 1.6 no longer supports the old way) #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zalmoxis
Copy link

No description provided.

@dragoon
Copy link

dragoon commented Aug 2, 2013

Agree on this, debug toolbar does not work under 1.6 anymore

@@ -7,7 +7,7 @@
try:
from django.conf.urls import patterns, url
except ImportError: # django < 1.4
from django.conf.urls.defaults import patterns, url
from django.conf.urls import patterns, url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong, the try and except clauses are identical.

@aaugustin
Copy link
Contributor

Thanks for your contribution. However, the patch isn't quite correct, as explained above.

The discussion is getting long for a three-line change. I'll close this PR and fix the problem separately.

@aaugustin aaugustin closed this Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants