Disable instrumentation for disabled panels #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the performance overhead when a panel is disabled.
Contributor
Author
|
Another nice side-effect of this pull request is that it (almost) eliminates import-time monkey-patching. This makes it safe to import the debug toolbar in any Python module. |
Contributor
Author
|
I don't know why the tests failed on Travis. They pass locally. |
aaugustin
added a commit
that referenced
this pull request
Nov 10, 2013
…sabled-panels Disable instrumentation for disabled panels
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
…ntation-for-disabled-panels Disable instrumentation for disabled panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request eliminates entirely the overhead of disabled panels.