Automatic setup with explicit fallback #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holy crap, on a cursory look this is amazing. Thanks @aaugustin! +1 |
aaugustin
added a commit
that referenced
this pull request
Nov 11, 2013
Simplify installation and provide more control.
This was referenced Nov 11, 2013
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Simplify installation and provide more control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very excited about this!
In the general case, it makes installing the debug toolbar as simple as adding
debug_toolbartoINSTALLED_APPS. (It isn't necessary to edit MIDDLEWARE_CLASSES any more).However, users retain full control of the installation: they can perform the installation steps explicitly instead. This will be especially helpful for people with complex URLconf setups that hit limits of the toolbar's support for per-request URLconfs. It should fix issues #441, #421, #300, #277, #254, #84 and make it possible to fix #448.
@robhudson @dcramer @jezdez do you think this will work?