Skip to content

Split JavaScript code between the toolbar itself and each panel #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Split JavaScript code between the toolbar itself and each panel #461

wants to merge 1 commit into from

Conversation

aaugustin
Copy link
Contributor

Fix #304

@aaugustin
Copy link
Contributor Author

With the technique I used in this first commit, panels don't have access to the djdt object when AMD JS is used.

I guess it would be possible to turn toolbar.js into an "AMD module" that panels can require to get access to djdt but that's way beyond my JavaScript skills.

@aaugustin
Copy link
Contributor Author

GitHub, I told you this pull request fixes #304...

@aaugustin
Copy link
Contributor Author

I'm not sure how to deal with the rest of the plugin-specific code contained in toolbar.js.

@aaugustin aaugustin closed this Nov 15, 2013
@aaugustin aaugustin deleted the refactor-javascript branch November 15, 2013 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for plugin static files
1 participant
@aaugustin