Stop bundling jQuery. #471
Conversation
|
@jezdez @robhudson Are you OK with this? jQuery accounts for more than two thirds of the size of the debug_toolbar package, and the world doesn't need yet another bundled copy ;-) |
|
I probably would have voted a -0 on this. I don't think the hassle of setting this up before you might go on a trip (or expect it to be there but it's not and you have no internet) outweighs the extra size to bundle it. But I wouldn't block it you guys think it's the way to go. |
|
Sure, it's difficult to quantify the advantages and drawbacks of this change. It's quite uncommon and challenging to do serious development work totally offline if you haven't prepared for it, for instance by ensuring you have the docs for your frameworks available offline. If you're missing jQuery, the toolbar won't appear. You may not even notice it — it's hard to notice that something isn't there! And if you understand that the toolbar doesn't load, and you really need it, you can probably find a copy of jQuery lying around on your laptop and inject it in the page... |
|
(As a side note, this change will make it easier for Linux distros to package the debug toolbar, if they ever want too. They frown upon bundled libraries.) |
…uery Stop bundling jQuery.
No description provided.