Put debug_toolbar's url patterns first #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications require using a catch-all urlpattern that must come last in the list of urlpatterns. If the __debug__ urls come after it, they'll never be hit. Putting the debug_toolbar urls first fixes this, but could possibly shadow an existing url, but the old version of debug toolbar did the same thing.
aaugustin
added a commit
that referenced
this pull request
Dec 12, 2013
Put debug_toolbar's url patterns first
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Put debug_toolbar's url patterns first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications require using a catch-all urlpattern that must come last in the list of urlpatterns. If the
__debug__urls come after it, they'll never be hit.Putting the debug_toolbar urls first fixes this, but could possibly shadow an existing url, but the old version of debug toolbar did the same thing.