Skip to content

Conversation

@ionelmc
Copy link

@ionelmc ionelmc commented Jan 21, 2014

No description provided.

@aaugustin
Copy link
Contributor

Could you clarify what the validation issues are?

@ionelmc
Copy link
Author

ionelmc commented Jan 26, 2014

Windows will send \r\n in the forms, instead of \n - making the hash
missmatch.

Thanks,
-- Ionel M.

On Sun, Jan 26, 2014 at 9:29 PM, Aymeric Augustin
notifications@github.comwrote:

Could you clarify what the validation issues are?


Reply to this email directly or view it on GitHubhttps://github.com//pull/533#issuecomment-33327338
.

@ionelmc
Copy link
Author

ionelmc commented Jan 26, 2014

It happens at least on Google Chrome on Win8

Thanks,
-- Ionel M.

On Sun, Jan 26, 2014 at 9:31 PM, Ionel Cristian Mărieș
contact@ionelmc.rowrote:

Windows will send \r\n in the forms, instead of \n - making the hash
missmatch.

Thanks,
-- Ionel M.

On Sun, Jan 26, 2014 at 9:29 PM, Aymeric Augustin <
notifications@github.com> wrote:

Could you clarify what the validation issues are?


Reply to this email directly or view it on GitHubhttps://github.com//pull/533#issuecomment-33327338
.

@aaugustin
Copy link
Contributor

Oh, yes, browsers standardize newlines in inputs to \n. (That makes javascript character counters notoriously hard to get right.) I didn't know they also did this for hidden inputs.

@aaugustin aaugustin closed this in 55636f2 Jan 26, 2014
@ionelmc
Copy link
Author

ionelmc commented Jan 26, 2014

Btw, it was a pull request not a bug report ... :-)

@aaugustin
Copy link
Contributor

I know, and I started from your patch, but then I wanted to make some changes, and eventually refactored the method entirely...

ryneeverett pushed a commit to ryneeverett/django-debug-toolbar that referenced this pull request Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants