Color-code SQL query "Timeline" stripes according to stacktrace #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,6 +198,10 @@ def process_response(self, request, response): | |||
| query['stacktrace'] = render_stacktrace(query['stacktrace']) | |||
| i += 1 | |||
|
|
|||
| if query['stacktrace'] not in trace_colors: | |||
| trace_colors[query['stacktrace']] = colors.next() | |||
There was a problem hiding this comment.
This isn't valid under Python 3, use next(colors). (Travis CI tells you about this problem.)
|
Overall I like your approach. It's very simple yet effective. However, the code could be a bit more elegant and robust. Would you mind updating it according to my comments? |
|
Thank you, Aymeric, for being so thorough with your code review! |
aaugustin
added a commit
that referenced
this pull request
Feb 12, 2014
Color-code SQL query "Timeline" stripes according to stacktrace
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Color-code SQL query "Timeline" stripes according to stacktrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is pretty simple except for the code to generate the colors, but that's isolated and thoroughly confirmed, though not unit tested. I'd be glad to adapt to your liking.