Deprecating INTERCEPT_REDIRECTS in favor of DEFAULT_DISABLED_PANELS. #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,13 @@ toolbar itself, others are specific to some panels. | |||
| Toolbar options | |||
| ~~~~~~~~~~~~~~~ | |||
|
|
|||
| * ``DEFAULT_DISABLED_PANELS`` | |||
|
|
|||
| Default: ``('RedirectsPanel', )`` | |||
There was a problem hiding this comment.
Could you use fully-qualified identifiers as in DEBUG_TOOLBAR_PANELS?
It's technically possible to have two panels with the same class name in different modules. That doesn't happen with built-in panels, but it could happen with external panels.
|
Thanks for the pull request, it looks pretty good. Can you adjust it according to my comments? |
…a set not a tuple.
|
@aaugustin Done. However, I did make one more adjustment. I made the definition use a set rather than a tuple. It made more sense to just have it always be a set as there's no need for ordering or duplicates in the collection. Thanks for the thorough review! |
aaugustin
added a commit
that referenced
this pull request
Mar 9, 2014
Deprecating INTERCEPT_REDIRECTS in favor of DEFAULT_DISABLED_PANELS.
|
FYI I changed the name of the setting and tweaked the documentation. |
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
…ls-by-default-510 Deprecating INTERCEPT_REDIRECTS in favor of DEFAULT_DISABLED_PANELS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to disable panels by config setting for #510.