Propagate mouseup events when not dragging toolbar #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chrome (this does not affect Firefox) onchange events on multi-selects are not fired all of the time e.g. with the following template:
<body>
<select multiple="multiple" onchange="console.log('clicked');">
<option value="1">1</option>
</select>
</body>
Ctrl click on the option and view the js log. many of the events will not register. Therefore stop propagation and prevent default action only when handle is dragged.
aaugustin
added a commit
that referenced
this pull request
Feb 26, 2014
Propagate mouseup events when not dragging toolbar
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Propagate mouseup events when not dragging toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome (this does not affect Firefox) onchange events on multi-selects are not fired all of the time e.g. with the following template:
Ctrl click on the option and view the js log. many of the events will not register. Therefore stop propagation and prevent default action only when handle is dragged.