JavaScript tests #647
Closed
JavaScript tests #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated test_toggle_switch_click to no longer try to test with the ProfilingPanel. The profiling panel wasn't consistent enough to return data for every run of the tests. Updated test_show_toolbar_button to wait until the show button is displayed before running the logic of the tests.`
Member
Author
|
So these tests with SauceLabs won't run on Pull Requests according to this. http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests |
Member
Author
|
@aaugustin Will there be a problem if I create a branch on the project's repo to test this integration? |
Contributor
|
No, feel free to create branches as needed. It isn't a big deal, and not even a small one. |
Member
Author
|
Closing this PR as I think all of the Travis build requests are marked as a Pull Request because of it. I'll submit a new one when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of selenium tests for the JavaScript functionality. It includes an integration with SauceLabs so Travis will be able to run them.
Note: I'm still not sure if the integration with SauceLabs will work, creating the PR is the first test of it.