Skip to content

Conversation

@apollo13
Copy link
Contributor

...o be defined)

@orokusaki
Copy link

Will this pull request be merged when 1.8b1 is released?

@hanleyhansen
Copy link

Anyone know when this will go in?

@tim-schilling
Copy link
Member

@aaugustin What do you think of creating a specific file to handle the different imports/functions based on the versions of Django? It should help restrict all the if/else logic into a single file and keep the rest of the project ignorant of it.

@aaugustin
Copy link
Contributor

@tim-schilling Yes, something like debug_toolbar.compat would be useful, especially when removing support for older Django versions.

@aaugustin
Copy link
Contributor

@tim-schilling Do you intend to work on this within the next few days?

@tim-schilling
Copy link
Member

I might not get to it until late this week or this weekend, but yes.

@aaugustin
Copy link
Contributor

I won't have time before the weekend either.

It would be good to upload a 1.8-compatible release as soon as possible. I suggest the first of us who has time writes the patch and the other reviews it :-)

@aaugustin
Copy link
Contributor

As of 22473d3 tests pass on Django 1.8 beta 1.

@aaugustin aaugustin closed this Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants