Undefine "define.amd" instead of "define", to allow other RequireJS modules to be loaded #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2015 12:16
When we undefine the entire window.define, modules loaded asynchronously can randomly fail to register themselves. However, jQuery 2+ checks for window.define.amd before registering itself as an AMD module, not just window.define. So, by unsetting window.define.amd instead of window.define, we don't break define() for other modules and we still prevent the page-global jQuery from registering itself as an AMD module, which was the ultimate goal of django-commons#591.
|
I don't want to have anything to do with this hack again, but this looks like an improvement. |
|
Thanks, @aaugustin. Is there someone else who could look at it, and/or anything I can do to help this along? |
|
I'll take a look. I should have some time this weekend.
|
…lbar into requirejs_backup_patch
|
Oh well let's merge it, we'll see what happens... |
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Undefine "define.amd" instead of "define", to allow other RequireJS modules to be loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By undefining the entire
window.define, issue #591 successfully prevents DDT's jQuery from registering itself with RequireJS under the "jquery" name. However, it also randomly prevents other RequireJS modules that are loading asynchronously from registering themselves viawindow.define(), since it's temporarilyundefined.This patch prevents jQuery from registering itself by unsetting
window.define.amd, rather thanwindow.define. As shown in #591, jQuery checks for a truthyamdproperty ofwindow.definebefore registering itself, so this patch still accomplishes the goal of #591. Sincewindow.defineis still a function, however, other modules will still be able to register withdefine().