Django Toolbar XML fix #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SQL Panel produces errors with XHTML documents, because of the `href` attribute in some links without a content. As result, the SQL Panel stays empty and an error occurs on the console. This sets the attributes to an empty content, which is valid XHTML.
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Django Toolbar XML fix
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
Like in Pull Request django-commons#793, the Timing Panel produces an error when used in XHTML documents. This time, the entity is undefined for XHTML documents. It was replaced by &django-commons#160; – which is the numeric pendant. Now the panel works for all kind of documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL Panel produces errors with XHTML documents, because of the
hrefattribute in some links without a content. As result, the SQL Panel stays empty and an error occurs on the console.This little fix sets the attributes to an empty content, which is valid XHTML.