Skip to content

Use Django's import_string so as to avoid re-implementing it #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Use Django's import_string so as to avoid re-implementing it #913

merged 1 commit into from
Feb 2, 2017

Conversation

jdufresne
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2017

Codecov Report

Merging #913 into master will increase coverage by 0.3%.

@@            Coverage Diff            @@
##           master     #913     +/-   ##
=========================================
+ Coverage   76.82%   77.12%   +0.3%     
=========================================
  Files          30       30             
  Lines        1661     1644     -17     
  Branches      246      245      -1     
=========================================
- Hits         1276     1268      -8     
+ Misses        311      303      -8     
+ Partials       74       73      -1
Impacted Files Coverage Δ
debug_toolbar/toolbar.py 79.71% <100%> (+3.8%)
debug_toolbar/panels/signals.py 76.59% <33.33%> (+4.59%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4959c6...d71a225. Read the comment docs.

@matthiask
Copy link
Member

Thanks! I just checked whether import_string is documented, and indeed it is.

@matthiask matthiask merged commit fcb1886 into django-commons:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants