Skip to content

Allow tests to pass with Django 2.0 #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Allow tests to pass with Django 2.0 #993

merged 1 commit into from
Nov 13, 2017

Conversation

jdufresne
Copy link
Contributor

Django 2.0 has removed the deprecated setting MIDDLEWARE_CLASSES. Use MIDDLEWARE instead.

As a result, adjust the the expected warnings during test as system check warning 1_10.W001 was removed.

Django 2.0 has removed the deprecated setting MIDDLEWARE_CLASSES. Use
MIDDLEWARE instead.

As a result, adjust the the expected warnings during test as system
check warning 1_10.W001 was removed.
@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files          28       28           
  Lines        1580     1580           
  Branches      236      236           
=======================================
  Hits         1326     1326           
  Misses        188      188           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e2e4c...73080e1. Read the comment docs.

@jdufresne
Copy link
Contributor Author

Given the Django support schedule and the deprecation policy, would it make sense to drop support for Django < 1.11 when adding support for 2.0? I can update this PR to drop all deprecated support if you agree it is a good idea.

@matthiask matthiask merged commit 5a56372 into django-commons:master Nov 13, 2017
@jdufresne jdufresne deleted the django20 branch November 13, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants