Add support for spatialite database backend #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is fine do drop support for python 3.7 |
@asherf it was updated ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for SpatiaLite database backend.
Unfortunately, due to a bug in SpatiaLite 5.0, the one that is supplied with Ubuntu 22.04, the database can not be properly initialized, which makes the e2e tests fail. That bug is fixed in SpatiLite 5.1, which is supplied with Ubuntu 24.04, hence the change to the runner OS.
With this change we are, however, not able to install Python 3.7 anymore, because it is no longer available for Ubuntu 24.04.
Since Python 3.7 is EOL, I think it's fine if we drop it from CI. If, however, we'd want to keep it, I'll have to figure out a way to install SpatiaLite on Ubuntu 22.04.