Add missing mimimal django version + prepare hotfix release #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Fixes: django-commons#474 Signed-off-by: Asher Foa <asher@asherfoa.com>
There was a problem hiding this comment.
Pull Request Overview
Adds a minimum Django requirement and finalizes a hotfix release (2.4.1).
- Enforce Django≥4.2 and <6.0 in install requirements
- Bump package version to 2.4.1
- Update CHANGELOG with the new release entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Add Django version constraint to dependencies |
| django_prometheus/init.py | Update package version to 2.4.1 |
| CHANGELOG.md | Document the 2.4.1 release |
Comments suppressed due to low confidence (1)
CHANGELOG.md:3
- [nitpick] Add a placeholder '## v2.5.0 - UNRELEASED' section below the new release entry to guide future changelog updates.
## v2.4.1 - June 25th, 2025
| @@ -45,6 +45,7 @@ def get_version(): | |||
| setup_requires=["pytest-runner"], | |||
| options={"bdist_wheel": {"universal": "1"}}, | |||
| install_requires=[ | |||
| "Django>=4.2,<6.0", | |||
There was a problem hiding this comment.
[nitpick] Consider adding trove classifiers for supported Django versions (e.g., 'Framework :: Django :: 4.2') in setup.py classifiers to improve package metadata clarity.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #474