Set history_user automatically using middleware #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,6 +224,19 @@ def create_historical_record(self, instance, type): | |||
| manager.create(history_date=history_date, history_type=type, | |||
| history_user=history_user, **attrs) | |||
|
|
|||
| def get_history_user(self, instance): | |||
| """Use hints from the instance and middleware to identify the | |||
There was a problem hiding this comment.
Minor nitpick: I prefer to follow PEP 257 for one line docstrings.
|
Can we only enable the middleware during relevant tests? Maybe |
|
This will pass once 1.3 is removed from the matrix in #103. |
|
This looks great for me. 👍 for merging. |
|
It is a good solution. Thanks for your efforts! |
macro1
added a commit
that referenced
this pull request
Aug 5, 2014
Set history_user automatically using middleware
macro1
added a commit
to macro1/django-simple-history
that referenced
this pull request
Aug 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional feature to populate
history_useron historical models using middleware to retrieve the request object.@treyhunner, @mauricioabreu I think this should be an acceptable implimentation of feature request #25. It probably could use a few tests around the new
get_history_usermethod, and the documentation could be clearer.